Ask Your Question
0

Why is gitlab CI failing for all packages except for Windows MinGW-w64 Package ?

asked 2023-07-27 19:43:49 +0000

riya gravatar image

Hi, I am new to wireshark development. I am trying to upstream my dissector but the gitlab CI is failing. this is the link to the CI -> https://gitlab.com/riyadixitagra/wire...

edit retag flag offensive close merge delete

Comments

You're following the steps in 3.10.1. Creating Merge Requests and SubmittingPatches?

Chuckc gravatar imageChuckc ( 2023-07-27 21:57:47 +0000 )edit

yes, I am.

riya gravatar imageriya ( 2023-07-28 03:52:59 +0000 )edit

1 Answer

Sort by ยป oldest newest most voted
0

answered 2023-07-28 07:09:27 +0000

Guy Harris gravatar image

updated 2023-07-28 09:17:05 +0000

Jaap gravatar image

If I look at the most recent pipeline for your pull request - which, rather than pipelines on your own repository, are what matter for upstreaming - the commit check job failed with

Checking: /builds/riyadixitagra/wireshark-pldm

License 'UNKNOWN' for 'epan/dissectors/packet-pldm-base.c' is not allowed.
License 'UNKNOWN' for 'epan/dissectors/packet-pldm-base.h' is not allowed.
License 'UNKNOWN' for 'epan/dissectors/packet-pldm.c' is not allowed.

FAILED

This is because you must, at minimum, have a comment header that specifies a license for the code. It should probably also include a copyright notice to go along with the license, plus some other information, e.g.:

/* {file name}
 * {Short summary of what's in the file}
 *
 * Wireshark - Network traffic analyzer
 * By Gerald Combs <[email protected]>
 * Copyright 1998 Gerald Combs
 *
 * {additional information if you want}
 *
 * SPDX-License-Identifier: GPL-2.0-or-later
 */

Try adding that to your source files (all three of them) in your personal GitHub repository; that should trigger a new build of the pull request.

(And ask further questions on your pull request, rather than here, so that the issues can be directly tracked on the pull request.)

edit flag offensive delete link more

Comments

(Not that 1998 is a requirement; see, for example, epan/epan.h, epan/epan_dissect.h, and epan/epan.c.)

Guy Harris gravatar imageGuy Harris ( 2023-07-28 09:31:20 +0000 )edit

Thanks. i will try this.

riya gravatar imageriya ( 2023-09-08 11:51:44 +0000 )edit

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Question Tools

Stats

Asked: 2023-07-27 19:43:49 +0000

Seen: 132 times

Last updated: Jul 28 '23