Ask Your Question
0

it's ok to sizeof(nspr_hd_v20_t) or it should be sizeof(nspr_pktracefull_v20_t) ?

asked 2020-01-10 12:01:49 +0000

updated 2020-01-10 12:03:50 +0000

grahamb gravatar image

the commit is : https://code.wireshark.org/review/git...

case NSPR_RELTIME_V20:
                 {
+                    if (!nstrace_ensure_buflen(nstrace, nstrace_buf_offset, sizeof(nspr_hd_v20_t), err, err_info))
+                        return FALSE;
                     nspr_pktracefull_v20_t *fp20 = (nspr_pktracefull_v20_t *) &nstrace_buf[nstrace_buf_offset];
                     if (nspr_getv20recordsize((nspr_hd_v20_t *)fp20) == 0) {
                         *err = WTAP_ERR_BAD_FILE;

the type of varible which will be used next is "nspr_pktracefull_v20_t", so i think sizeof(nspr_pktracefull_v20_t) is better

edit retag flag offensive close merge delete

1 Answer

Sort by ยป oldest newest most voted
0

answered 2020-01-10 12:21:12 +0000

grahamb gravatar image

Wireshark Bugzilla, or even better the actual change on Gerrit where the context is obvious is the best place for such observations.

This does look like an error.

edit flag offensive delete link more

Comments

OK,thank you, i'll try

eaglegai gravatar imageeaglegai ( 2020-01-13 01:20:27 +0000 )edit

fix link :https://code.wireshark.org/review/#/c/35837/

eaglegai gravatar imageeaglegai ( 2020-01-17 01:38:54 +0000 )edit

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Question Tools

1 follower

Stats

Asked: 2020-01-10 12:01:49 +0000

Seen: 52 times

Last updated: Jan 17