Can CP1252 encoding support be added to the follow stream window; if so it would provide better support for my new font to display bytes in ASCII-8 character form with CP1252 , more info on https://github.com/dernyn/256
please understand what CP1252 encoding is before commenting or denying my request.
If you mean "interpret the characters in the byte stream as CP1252 characters, so that bytes with the 8th bit set are to be interpreted as being in CP1252, that could probably be added. File an enhancement request on the Wireshark Bugzilla.
Wireshark will, however, continue to use UTF-8 internally, with Qt using, I think, UTF-16 inside its strings. It's not ever going to be using CP1252 internally. If you want to use your font, it'd better be a font that Qt can use.
As it's apparently so simple please submit your change as detailed on the Wiki page Submitting patches.
if you followed the link,
I DID follow the link. The only thing it shows about Qt is a display inside Qt Creator. None of that indicates what you're asking for.
Your text first speaks of non-Unicode encodings:
This Font works best with character Region English - Western/Latin1 encoding providing single-byte character encoding with CP1252/Windows-1252/IBM819/CP819/iso-ir-100/csISO-Latin1/ibm-5348 and ISO-8859-1 depending on Text editor support.
This Font does not support UTF-8 encoding, Inherently Fails to fully encode in UTF-8 due to it's native lack of single-byte character support by the standard, which is limited to ASCII-7 (128).
but then says it's a Unicode-encoded font:
It is an ISO 10646-1(Unicode,BMP) encoded True-Type Font(TTF)
If it's a Unicode-encoded font, so that any software that handles Unicode can use it to display, at least, the subset of Unicode that includes the characters in ...
@grahamb thanks for all your help, It seems I have angered you by my comments. I did Open the enhancement request as indicated. I may just make the changes in the code myself and provide a patch, but I was avoiding having to do so if it's a new add feature, I don't get the push back or the shaming for my suggestion that it can't be that hard, as if what I am requesting is impossible to do. it's a native API call in the Qt SDK, it can't be that hard is all I'm indicating.
Qt Creator is no different than Qt as a GTK+ programming interface with support for all these different encoding within itself , what I hence at is that if it works in Qt creator it works in any Qt API call by other apps. why does it feels ...
@Dernyn, no problem at all, but as you seem to be the only person requesting this change it's unlikely to happen unless you step up to the plate and submit the required change, this isn't being awkward or pushing back, just stating reality.
I didn't see any mention in the question or comments that an item has been raised on Bugzilla.
The Wireshark devs are generally welcoming and grateful for all changes submitted and requests made, but as we are all volunteers (except Gerald) we don't have much spare time for investigating and implementing what seems to be an esoteric request.
I did Open the enhancement request as indicated.
Presumably that's bug 16137.
So, just because a font is Unicode capable - meaning it can allocate mappings in the Unicode regions( ISO 10646-1(Unicode,BMP), it does not mean it covers UTF-8. UTF-8 is not the defacto Unicode standard or mapping. CP1252/ISO-8859-1 is covered/supported in the Unicode mappings and that's why my font works the way it does.
if you tried to use my font in a UTF-8 encoding, it will not render correctly because is not a UTF-8/16 Font, although it is a Unicode Font. Unicode does not just means UTF-8 support, that's just a subset of the Unicode available mapping.
I also can't have UTF-8 and CP1252/ISO-8859-1 in one font, they are two different subsets encodings of Unicode, supporting different sections of the Unicode Map.
Unicode assigns "a unique number for every character, no matter what platform, device, application or language."
UTF-8 and UTF-16 are ...
This is how Qt Creator does it.
QString utf16LineTextInUtf8Buffer(const QByteArray &utf8Buffer, int currentUtf8Offset)
{
const int lineStartUtf8Offset = currentUtf8Offset
? (utf8Buffer.lastIndexOf('\n', currentUtf8Offset - 1) + 1)
: 0;
const int lineEndUtf8Offset = utf8Buffer.indexOf('\n', currentUtf8Offset);
return QString::fromUtf8(
utf8Buffer.mid(lineStartUtf8Offset, lineEndUtf8Offset - lineStartUtf8Offset));
}
static bool isByteOfMultiByteCodePoint(unsigned char byte)
{
return byte & 0x80; // Check if most significant bit is set
}
bool utf8AdvanceCodePoint(const char *¤t)
{
if (Q_UNLIKELY(*current == '\0'))
return false;
// Process multi-byte UTF-8 code point (non-latin1)
if (Q_UNLIKELY(isByteOfMultiByteCodePoint(*current))) {
unsigned trailingBytesCurrentCodePoint = 1;
for (unsigned char c = (*current) << 2; isByteOfMultiByteCodePoint(c); c <<= 1)
++trailingBytesCurrentCodePoint;
current += trailingBytesCurrentCodePoint + 1;
// Process single-byte UTF-8 code point (latin1)
} else {
++current;
}
return true;
}
Asked: 2019-10-01 21:04:48 +0000
Seen: 550 times
Last updated: Oct 17 '19
Copyright Wireshark Foundation, 2017-2023 Content on this site is licensed under a Creative Commons Attribution Share Alike 3.0 license.