Howto port plugin code from Linux to Windows

asked 2018-04-17 04:38:10 +0000

this post is marked as community wiki

This post is a wiki. Anyone with karma >750 is welcome to improve it.

I have added a plugin which is working fine in a Linux environment, when I am porting the same code on Windows and trying to compile it's showing an error.

I am following the same steps as given in Readme.plugin document but looks like document is updated long back. Every time it's giving same error - C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommonmon.targets(170,5): error MSB6006: "cmd.exe" exited with code 1. [C:\Deelopment\wsbuild64_2\plugins\rxd\rxd.vcxproj]

I have changed the below files on Windows environment, kindly let me know if I am missing something?

  1. have added entry of plugin in Configure.ac file in wireshark directory
  2. have added entry of plugin in Configure file in wireshark directory
  3. In Cmakelist.txt
  4. have added in Makefile.am and Makefile.in
  5. in wireshark\plugin also i have added my changes in Makefile.am, Makefile.in
  6. I have added me changes in wireshark/epan/Makefile.am and wireshark/epan/Makefile.in also .
  7. at last for making .dll file for my plugin i have added entry in wireshark/packaging/nsis/wireshark.nsi file also.

Kindly let me know what i am missing?

Thanks & Regards Ritesh

edit retag flag offensive close merge delete

Comments

For Windows, only the CMake build system is used, so I think only 3. and 7. apply.

Can you provide the output of both the CMake generation step (cmake -G ...) and the build attempt (msbuild ...), redirecting the output to a file by appending 2>&1 > file.txt, using a different file for cmake generation and build, and then upload those files to a public file share, e.g. Google Drive, DropBox and then editing your question to add links to those files?

grahamb gravatar imagegrahamb ( 2018-04-17 08:10:16 +0000 )edit

HI Graham,Thanks for the response . I have seen the steps on Readme.plugins in community itself ,They are also stating that we need to add our changes to Makefile also .. attaching the link for your reference - https://github.com/wireshark/wireshar...

KIndly confirm .

Thanks , Ritesh

Ritesh Mishra gravatar imageRitesh Mishra ( 2018-04-17 10:41:33 +0000 )edit

I was only pointing out that on Windows, the autotools files are unused, so changing them makes no difference. The documentation is generic and makes no distinction between build platforms as a submission of a plugin to Wireshark would need both build systems to be updated.

To resolve your issue we need the output from the build steps I mentioned in my previous comment.

grahamb gravatar imagegrahamb ( 2018-04-17 11:09:05 +0000 )edit
add a comment